Do not use cmd shell in GitHub Actions #9327
Open
+22
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
changed the title
hugovk
reviewed
Dec 10, 2025
Comment on lines
-189
to
-206
| setlocal EnableDelayedExpansion | ||
| for %%f in (winbuild\build\license\*) do ( | ||
| set x=%%~nf | ||
| rem Skip FriBiDi license, it is not included in the wheel. | ||
| set fribidi=!x:~0,7! | ||
| if NOT !fribidi!==fribidi ( | ||
| rem Skip imagequant license, it is not included in the wheel. | ||
| set libimagequant=!x:~0,13! | ||
| if NOT !libimagequant!==libimagequant ( | ||
| echo. >> LICENSE | ||
| echo ===== %%~nf ===== >> LICENSE | ||
| echo. >> LICENSE | ||
| type %%f >> LICENSE | ||
| ) | ||
| ) | ||
| ) | ||
| call winbuild\\build\\build_env.cmd | ||
| %pythonLocation%\python.exe -m cibuildwheel . --output-dir wheelhouse |
Member
There was a problem hiding this comment.
We can keep this chunk, it doesn't declare shell: cmd so will default to pwsh.
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#defaultsrunshell
And zizmor doesn't complain about it.
Member
Author
There was a problem hiding this comment.
I don't think this is the case. The shell: cmd on line 220 is related to this block.
I've separated this change out from the other changes, and you can see that without it, zizmor does complain - https://results.pre-commit.ci/run/github/5171600/1765401638.xj0JlAmBT_6lRfMDGmxoqQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9318 upgraded zizmor to include https://docs.zizmor.sh/audits/#obfuscation
This PR allows for that by