#1627: Removed feedback_to_output settable and made pfeedback consistent#1647
#1627: Removed feedback_to_output settable and made pfeedback consistent#1647
Conversation
…utput. (#1627) * Made the set command silent on success by default. * Added a -v/--verbose flag to the set command to display change confirmations. * Consolidated the verbose output into a single, colorized line (e.g., param: old -> new). * Updated unit tests to reflect the new default behavior and output format.
* Updated do_set to use pfeedback for change confirmations, allowing it to be silenced via the quiet setting. * Updated unit tests to match the new output format and verify quiet mode behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
- Coverage 99.52% 99.52% -0.01%
==========================================
Files 21 21
Lines 4817 4813 -4
==========================================
- Hits 4794 4790 -4
Misses 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@bambu I need to consider this. I don't think the previous output was too verbose. I'm OK if we reformat it, but the amount of information displayed was, in my view, reasonable. I'm also concerned about the new output being on one line. A Help me understand the reason behind this change. Are you running |
New format looks like:
```sh
myapp> set allow_style always
allow_style: 'Terminal'
-> 'Always'
```
Where "'Terminal'" is red and "'Always'" is green.
This is still more abbreviated than the original format, but not as abbreviated as putting everything on one line. Moreover, it preserves the more colorful diff-style display and the switch to using pfeedback.
|
@bambu @kmvanbrunt
|
|
@bambu |
9909afb to
9105ed2
Compare

Description
This PR removes the
feedback_to_outputsettable. It also does the following:pfeedbackalways outputs toself.stdoutwhen thequietsettable isFalsaecmd2now makes more consistent use ofpeedbackfor non-essential output that is silenceablestderr, but without any color or stylequietis set. The previous output was overly verbose (three lines) and could not be silenced.Closes #1627