Restrict decorating async methods with sync enignes of Redis, Mongo and SQL cores#336
Merged
shaypal5 merged 25 commits intopython-cachier:masterfrom Feb 17, 2026
Conversation
…ongo and SQL cores
shaypal5
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING :: This branch/PR requires Mongo wire 8 and above, while only Mongo wire 7 is supported in this GH CI configuration.
Primary: raise exception on decorating an async function if the sync client is provided with Redis, SQL and Mongo clients. The reason: sync clients / sessionmakers almost completely wipe benefits of caching results of async functions, especially, over OS protocols, while the codebase becomes simpler without overhead isawaitable checks.
Secondary: