Skip to content

reduce gc_collect_harder default to 1 on CPython #14441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
miketheman wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Draft

reduce gc_collect_harder default to 1 on CPython #14441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/_pytest/unraisableexception.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,14 @@ def collect_unraisable(config: Config) -> None:
def cleanup(
*, config: Config, prev_hook: Callable[[sys.UnraisableHookArgs], object]
) -> None:
# A single collection doesn't necessarily collect everything.
# Constant determined experimentally by the Trio project.
gc_collect_iterations = config.stash.get(gc_collect_iterations_key, 5)
# On PyPy, objects (e.g. coroutines) can survive GC rounds because executing
# their __del__ can resurrect them. The Trio project determined experimentally
# that 5 passes are needed on PyPy to flush everything. On CPython, reference
# counting handles most cleanup immediately, so 1 pass is sufficient.
_default_gc_collect_iterations = 5 if hasattr(sys, "pypy_version_info") else 1
gc_collect_iterations = config.stash.get(
gc_collect_iterations_key, _default_gc_collect_iterations
)
try:
try:
gc_collect_harder(gc_collect_iterations)
Expand Down
Loading