fix: catch OSError in _read_pyc file read#14304
Open
themavik wants to merge 1 commit intopytest-dev:mainfrom
Open
fix: catch OSError in _read_pyc file read#14304themavik wants to merge 1 commit intopytest-dev:mainfrom
themavik wants to merge 1 commit intopytest-dev:mainfrom
Conversation
Root cause: The file read operation in _read_pyc was outside the try/except block, so I/O errors during fp.read() were not caught, causing crashes with pytest-xdist. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14112.
Root cause: The file read operation in
_read_pycwas outside thetry/exceptblock, soOSErrorduringfp.read()was not caught. This caused crashes when using pytest-xdist, where concurrent file access can trigger I/O errors.Fix: Moved the file read into the try/except block to properly catch
OSError.Changes
src/_pytest/assertion/rewrite.py: Movedwith fp:into the try blockTesting
Made with Cursor