Updated Polyscript & Coincident to their latest#2327
Merged
WebReflection merged 1 commit intopyscript:mainfrom Apr 23, 2025
WebReflection:coincident-rewrite
Merged
Updated Polyscript & Coincident to their latest#2327WebReflection merged 1 commit intopyscript:mainfrom WebReflection:coincident-rewrite
WebReflection merged 1 commit intopyscript:mainfrom
WebReflection:coincident-rewrite
Conversation
Contributor
Author
|
this put a big smile on my face, it's usually 3 up to 5 but on average I've seen 30 seconds less time, compared to other normal builds ... meaning there is some gain. Locally, it used to take ~32 seconds and now is more like ~19 for the pyodide in worker case ... and like I've said, there's more to do but as a starter, and a fundamental change in the deepest part of our core, I hope this improvement is welcomed. |
danyeaw
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This MR is a follow up of this one: pyscript/polyscript#132
It's meant to test improvements (or possible issues) in CI or in the wild, using the latest single rountrip and simplified coincident approach.
Changes
Checklist
make buildworks locally.