Add case insensitivity tests for arbitrary equality #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
force-pushed
the
test-case-insensitivity-of-arbitary-equality
branch
from
00bbeb3 to
a8e4faf
Compare
Contributor
|
Would it make sense to put this one in first, then compare with the other one? This only adds tests for current behavior. |
Member
Author
|
I guess that's a philosophical question on what tests are for, ensuring existing behavior or ensuring spec complaint behavior, I don't have a strong opinion but I've heard other PyPA maintainers express opinions towards the latter. |
brettcannon
approved these changes
Nov 14, 2025
Contributor
|
I think this is just waiting for pypa/packaging.python.org#1959 to go in (though I guess we could merge sooner, as it's only tests that pass on the existing implementation). |
Member
|
@henryiii yep, it can either go in now and possibly be reverted based on the DPO discussion, or it can wait until there's an official answer (I'm fine with either approach). |
henryiii
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #974
By enshrining the current behavior in tests.
Counter to #976