Fix monitoring of functions

[alexrudd2]

Caught by pyright :)

[janiversen]

This one seems wrong.

[janiversen]

This is wrong, you are now building a list of object pointers and not function codes !

[janiversen]

This seems wrong, it is a list of function codes, not object pointers.

[alexrudd2]

You have to look at the surrounding context. list_function_codes() -> list[int]
Therefore function is an int.
Therefore, function.function_code does not exist, and the existing code is broken in some manner.
(It's never called in tests and has # pragma: no cover so the breakage is not detected.)

pymodbus/pymodbus/pdu/decoders.py

Lines 34 to 36 in 431fb6c

	def list_function_codes(self):
	"""Return list of function codes."""
	return list(self.pdu_table)

pymodbus/pymodbus/server/simulator/http_server.py

Lines 372 to 378 in 431fb6c

	for function in DecodePDU(True).list_function_codes():
	selected = (
	"selected"
	if function.function_code == self.call_monitor.function
	else ""
	)
	function_codes += f"<option value={function.function_code} {selected}>function code name</option>"

Perhaps something like the code below was the intention? Although I don't really see the advantage over my first code.

for function in DecodePDU(True).pdu_table.values():
    req_func, _res_func = function
     selected = (
        "selected"
         if req_func.function_code == self.call_monitor.function
          else ""
      )
      function_codes += f"<option value={req_func.function_code} {selected}>function code name</option>"