Improve AdvancedSubtensor and AdvancedIncSubtensor#1910
Open
aman-coder03 wants to merge 6 commits intopymc-devs:mainfrom
Open
Improve AdvancedSubtensor and AdvancedIncSubtensor#1910aman-coder03 wants to merge 6 commits intopymc-devs:mainfrom
aman-coder03 wants to merge 6 commits intopymc-devs:mainfrom
Conversation
ricardoV94
reviewed
Feb 23, 2026
pytensor/tensor/subtensor.py
Outdated
| def __str__(self): | ||
| return f"{self.__class__.__name__}{{{Subtensor.str_from_indices(self.idx_list)}}}" | ||
| return ( | ||
| f"{self.__class__.__name__}{{{Subtensor.str_from_indices(self.idx_list)}}}" |
Member
There was a problem hiding this comment.
you can move str_from_indices to BaseSubtensor
ricardoV94
reviewed
Feb 23, 2026
pytensor/tensor/subtensor.py
Outdated
| def __str__(self): | ||
| name = "SetSubtensor" if self.set_instead_of_inc else "IncSubtensor" | ||
| return f"{name}{{{Subtensor.str_from_indices(self.idx_list)}}}" | ||
| return f"{name}{{{BaseSubtensor.str_from_indices(self.idx_list)}}}" |
Author
There was a problem hiding this comment.
done, updated to use super() instead
Member
There was a problem hiding this comment.
I think you're missing a couple more
Author
There was a problem hiding this comment.
yeah was updating them too! sorry for the confusion!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the string representation of
AdvancedSubtensorandAdvancedIncSubtensorto include their index information, making debug output more consistent withSubtensorPreviously, calling
dprint()on advanced indexing operations would display only the operator name (e.g.,AdvancedSubtensor) without showing the indices used. This made debugging and graph inspection harderthis PR,
adds a
__str__implementation toAdvancedSubtensorthat formats indices usingSubtensor.str_from_indicesupdates
AdvancedIncSubtensor.__str__to include formatted indiceskeeps behavior consistent with existing
SubtensorrepresentationsRelated Issue
Checklist
Type of change