Add canonicalization rewrite for useless cumsum/cumprod on length-1 axes#1904
Open
alessandrogentili001 wants to merge 2 commits intopymc-devs:mainfrom
Open
Add canonicalization rewrite for useless cumsum/cumprod on length-1 axes#1904alessandrogentili001 wants to merge 2 commits intopymc-devs:mainfrom
alessandrogentili001 wants to merge 2 commits intopymc-devs:mainfrom
Conversation
ricardoV94
reviewed
Feb 21, 2026
Member
ricardoV94
left a comment
ricardoV94
left a comment
There was a problem hiding this comment.
Looks, good some minor comments
| When ``cumsum`` or ``cumprod`` is applied along an axis of length 1, | ||
| the result is identical to the input, so the operation can be removed. | ||
| """ | ||
| if not isinstance(node.op, CumOp): |
Member
There was a problem hiding this comment.
not needed, tracks enforce it
| ((3, 4), 0, "mul", False), | ||
| ], | ||
| ) | ||
| def test_local_CumOp_length1(shape, axis, mode, should_rewrite): |
Member
There was a problem hiding this comment.
simplify tests, case is simple enough that we can just rewrite and check the rewrite applies or does not. Also no need for so many combinations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Type of change