-
Notifications
You must be signed in to change notification settings - Fork 27
Update for pyload-ng, replace Thrift client with REST client #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sab44
wants to merge
14
commits into
pyload:master
Choose a base branch
from
Sab44:update-for-pyload-ng
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove FileChooser as Android 11+ no longer supports filepaths
This was referenced May 27, 2025
* logout call added * DownloadInfo waitUntil changed to float (changes are not relevant to current app functionality)
* omitting timestamps makes verifying changes in the git diff easier
* switch to basic auth
* change rest methods where needed
* change speed variables to Long (Int64) type
Author
|
If someone wants to try out an alternative, see: https://github.com/Sab44/omni_for_pyload |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #42
Note: the app will only work against a pyLoad server that has the changes from pyload/pyload#4580 incorporated.
The existing custom File Chooser had to be removed to work with modern Android versions.
Important:
This will restore basic functionality of the app. There will likely be bugs related to things no longer working on modern Android versions similar to the File Chooser. Any bug fixes should be done in follow-up PRs.
Tested:
Currently untested: