Skip to content

Rename pixelratio -> ratio, send close event #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
almarklein merged 3 commits into from
Mar 19, 2026
Merged

Rename pixelratio -> ratio, send close event #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28cd754
Send close event and fix show/hide timestamp key
almarklein Mar 18, 2026
7e6a7cc
Also rename pixelratio -> ratio
almarklein Mar 19, 2026
6b91541
update date
almarklein Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/renderview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,11 @@ class BaseRenderView {
this.wrapperElement.innerHTML = ''
this.wrapperElement = null
}
const event = {
type: 'close',
timestamp: getTimestamp()
}
this.onEvent(event)
}

/**
Expand Down Expand Up @@ -395,7 +400,7 @@ class BaseRenderView {
this._isVisible = isVisible
const event = {
type: isVisible ? 'show' : 'hide',
t: getTimestamp()
timestamp: getTimestamp()
}
this.onEvent(event)
}
Expand Down Expand Up @@ -461,7 +466,7 @@ class BaseRenderView {
height: logicalHeight,
pwidth: physicalWidth,
pheight: physicalHeight,
pixelratio: ratio,
ratio,
timestamp: getTimestamp()
}
this.onEvent(event)
Expand Down
4 changes: 2 additions & 2 deletions src/spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

A protocol for interactive rendering surfaces.

*Last update: 18-03-2026*
*Last update: 19-03-2026*

*This spec was previously known as the jupyter_rfb event spec, but was rolled into a separate project.*

Expand Down Expand Up @@ -70,7 +70,7 @@ Fields:
* `height`: The height in logical pixels.
* `pwidth`: The width in physical pixels.
* `pheight`: The height in physical pixels.
* `pixelratio`: The pixel ratio between logical and physical pixels.
* `ratio`: The pixel ratio between logical and physical pixels.
* `timestamp`: A timestamp in seconds.


Expand Down
Loading