Add pyproject.toml file #16
Conversation
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
nice, thank you, only minor comments
copier.yml
Outdated
| keywords: | ||
| type: str | ||
| help: "Keywords to help categorize the project (e.g., on PyPI)." | ||
| default: "'acoustics','pyfar'" |
There was a problem hiding this comment.
Can we also do it here without ' to uniform it with dependencies.
There was a problem hiding this comment.
Of course. But should we add quotation marks in the pyproject.toml file, as we do for dependencies? Or should we leave the keywords without quotation marks at all?
There was a problem hiding this comment.
yes, we can add them in pyproject.toml, as we did for the dependencies.
The quotation marks are required in the pyproject.toml.
| spaces between them. These dependencies will be included in the pyproject.toml file. | ||
| default: "numpy,scipy" | ||
|
|
||
| valid_python_versions: |
There was a problem hiding this comment.
| valid_python_versions: | |
| _valid_python_versions: |
maybe we can add _ to make clear that they are private
There was a problem hiding this comment.
Thank you for the review!!
I found out that adding _ to the parameters marks them as secret. This is stated on the copier website. If I understand correctly, the answers to such questions are not stored in the .copier-answers.yml file and cannot be used without being explicitly stored in another parameter.
I don't think we want that kind of behavior, so I wouldn't add a _ to the names.
| {% set min_index = versions.index(minimum_python_version) %} | ||
| {{ versions[min_index:] }} | ||
| pypi_license_classifiers_list: |
There was a problem hiding this comment.
| pypi_license_classifiers_list: | |
| _pypi_license_classifiers_list: |
| EUPL-1.2: "License :: OSI Approved :: European Union Public Licence 1.2 (EUPL 1.2)" | ||
| MPL-2.0: "License :: OSI Approved :: Mozilla Public License 2.0 (MPL 2.0)" | ||
|
|
||
| pypi_license_classifier: |
There was a problem hiding this comment.
| pypi_license_classifier: | |
| _pypi_license_classifier: |
tests/test_copier.py
Outdated
| 'description = "my_project_short_description"', | ||
| 'requires-python = ">=3.11"', | ||
| "'acoustics',", | ||
| "'pyfar'", |
There was a problem hiding this comment.
| "'pyfar'", | |
| "\n 'pyfar',\n", |
maybe also check if the indent is corret. This could also be applied to other paramters
Which issue(s) are closed by this pull request?
Closes #13
Changes proposed in this pull request:
pyproject.tomlto the template directory.pyproject.tomlfile, updated thetest_generated_file_exists()function.copier.yml:project_short_description,version,keywords,pypi_license_classifiers_list,pypi_license_classifier