Skip to content

Use StringDType when reading from zarr string variables #11097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jsignell wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Use StringDType when reading from zarr string variables #11097

jsignell wants to merge 5 commits into from
+12 −2

Conversation

@jsignell
Copy link
Member

@jsignell jsignell commented Jan 21, 2026 •
edited
Loading

Down to 4 failures locally which all seem to have special handling for zarr_3 so should be quick to fix

FAILED xarray/tests/test_backends.py::TestZarrNoConsolidatedMetadataSupport::test_roundtrip_empty_vlen_string_array[3] - AssertionError: assert False
FAILED xarray/tests/test_backends.py::TestZarrDirectoryStore::test_roundtrip_empty_vlen_string_array[3] - AssertionError: assert False
FAILED xarray/tests/test_backends.py::TestZarrWriteEmpty::test_roundtrip_empty_vlen_string_array[3] - AssertionError: assert False
FAILED xarray/tests/test_backends.py::TestZarrDictStore::test_roundtrip_empty_vlen_string_array[3] - AssertionError: assert False

@github-actions github-actions bot added topic-backends topic-zarr Related to zarr storage library topic-arrays related to flexible array support io labels Jan 21, 2026
@jsignell jsignell changed the title String dtype Use StringDType when reading from zarr string variables Jan 21, 2026
@jsignell jsignell marked this pull request as ready for review January 22, 2026 14:23
@jsignell jsignell linked an issue Jan 22, 2026 that may be closed by this pull request
Fix NA semantics for numpy.StringDType #10967
Open
5 tasks
@jsignell jsignell mentioned this pull request Jan 22, 2026
Open
5 tasks
alippai
alippai reviewed Jan 22, 2026
View reviewed changes
xarray/core/duck_array_ops.py
# timedelta64 inherits from np.integer
return isnat(data)
elif HAS_STRING_DTYPE and isinstance(scalar_type, np.dtypes.StringDType):
return xp.isnan(data)
Copy link

@alippai alippai Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StringDType has a custom na_object property. Is that relevant here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alippai alippai alippai left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

io topic-arrays related to flexible array support topic-backends topic-zarr Related to zarr storage library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Zarr chunks ignored when reading arrays with StringDType Fix NA semantics for numpy.StringDType

2 participants

@jsignell @alippai