Enforce typed defs in httpx2 tests#987
Merged
Merged
Conversation
Remove the last `disallow_untyped_defs = false` mypy override (`tests.httpx2.*`) so the whole test suite is held to strict typing, and annotate the flagged functions with parameter and return types.
Merging this PR will not alter performance
Comparing 
Footnotes
|
The coverage `exclude_also` from #988 now excludes `if TYPE_CHECKING:` blocks globally, so the per-block `# pragma: no cover` is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last
disallow_untyped_defs = falsemypy override (tests.httpx2.*), so the entire test suite is now held to strict typing alongside the source. Annotates the 535 functions this flagged: ~388 just needed-> None, ~147 needed parameter types (fixtures, ASGI/WSGI scope/receive/send handlers, parametrized values, event-hook dicts).The transport subclasses in the context-manager tests gained an explicit
return selfin__enter__/__aenter__to satisfy the base-> Selfcontract; behavior is unchanged (the tests don't bind theastarget).mypy, ruff check/format, the unasync
--check, and the affected test files all pass.AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.