Fix URL.host decoding for nested IDNA labels#979
Draft
Abdulmumin1 wants to merge 3 commits into
Draft
Conversation
Abdulmumin1
force-pushed
the
fix-url-host-nested-idna
branch
from
9960ca4 to
9bac192
Compare
mbeijen
reviewed
May 23, 2026
| host = idna.decode(host) | ||
| if any(label.startswith("xn--") for label in host.split(".")): | ||
| try: | ||
| host = idna.decode(host) |
Contributor
There was a problem hiding this comment.
you decode the complete host, you should probably try to decode each label and assemble them back together.
See the httpxyz fix at https://codeberg.org/httpxyz/httpxyz/src/commit/dc2bdf61f9d2061d89040dcd4babc1686c5de5bc/httpxyz/_urls.py#L194-L205
Author
There was a problem hiding this comment.
thanks! i've updated accordingly
Member
|
I've opened kjd/idna#248 on idna's side. I don't think we should be handling it on our side. I'll wait for their reply to take a decision here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #850.
Summary
URL.hostidnaexceptions from the propertywww.égalité-femmes-hommes.gouv.fr