Add IPNetPattern for accurate CIDR proxy/mount matching#969
Open
mbeijen wants to merge 1 commit into
Open
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
Setting no_proxy patterns matched by hostname string comparison. So 192.168.0.1 would not match all://192.168.0.0/16. Add IPNetPattern, backed by ipaddress.ip_network, and a build_url_pattern() factory that returns IPNetPattern for all:// patterns containing a slash and WildcardURLPattern otherwise. Introduce a Pattern protocol so Client and AsyncClient can hold either kind in their _mounts dict. URLPattern is kept as a backward-compatible alias for WildcardURLPattern. Together with pydantic#967 will close - pydantic#829 - pydantic#899 Ported from encode/httpx#3741. Co-Authored-By: Ondrej Filip <ondrej.filip@firma.seznam.cz> Co-Authored-By: Bill Peck <bpeck@redhat.com>
mbeijen
force-pushed
the
fix-no-proxy-cidr-matching
branch
from
13221ad to
eb703b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting no_proxy patterns matched by hostname string comparison. So 192.168.0.1 would not match all://192.168.0.0/16.
Add IPNetPattern, backed by ipaddress.ip_network, and a build_url_pattern() factory that returns IPNetPattern for all:// patterns containing a slash and WildcardURLPattern otherwise. Introduce a Pattern protocol so Client and AsyncClient can hold either kind in their _mounts dict.
URLPattern is kept as a backward-compatible alias for WildcardURLPattern.
Together with #967 will close
Ported from encode/httpx#3741.