pybricks.pupdevices.Remote: Fix bad color due to aliasing violation. #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
I think "type punning" is the term you are looking for.
GCC does have a warning for this, but So sounds more like a bug in GCC or the |
dlech
approved these changes
Dec 22, 2025
This broke in newer GCC versions, causing the LED to get the wrong color. Fixes pybricks/support#2497
laurensvalk
force-pushed
the
issue-2497
branch
from
e2b9772 to
9b8c514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke in newer GCC versions, causing the LED to get the wrong color.
Fixes pybricks/support#2497
Edit: Maybe this isn't the technically correct terminology for this error. It would be nice if we could catch these automatically.