-
Notifications
You must be signed in to change notification settings - Fork 39
ev3: Fix issues with flashing (some?) EV3s. #2352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaguilar
wants to merge
4
commits into
pybricks:master
Choose a base branch
from
jaguilar:ev3-flash-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+118
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurensvalk
reviewed
Dec 20, 2025
Member
EDIT: I'll collect some notes in the issue thread instead. |
9cd1a76 to
e9e075f
Compare
dlech
reviewed
Dec 23, 2025
Member
|
It seems like this is fixing at least 3 different things. So would be better to split it up into 3 commits.
|
This fixes an issue where the EV3 firmware had checksums appended to it that made its size not align to the sector size, causing flashing to fail.
We don't use this datum for anything, and the rest of the flashing process apparently proceeds fine even if this fails. This could use further investigation, though.
Research in pybricks/support#2375 (comment) and below shows that erasing the firmware and writing it sector by sector causes hangs during the flashing process. Instead, we should erase the whole firmware at once, and flash it at once. This successfully loads new EV3 firmware without hangs.
e9e075f to
c4e66ee
Compare
Author
c4e66ee to
92dc7f6
Compare
If the EV3 firmware size is not a multiple of the sector size, the flashing process will hang. Raise an error if this happens.
92dc7f6 to
1528acf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Flash the EV3 all in one go rather than sector-by-sector. This appears to resolve issues we had with flashing (some?) EV3s, and mirrors what we do in pybricksdev.
Fixes pybricks/support#2375.