A number of improvements #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found the matrix with modifications difficult to follow. The config matrix variant is much easier to understand.
I want to support syntax changes in the 3.12 stubs. This requires having a different version before this.
* Add error logs for each pybind11 version stubgen generates less errors with code from pybind11 v3.0 so it needs its own error log file * Fix symbolic links
* Replace setup.py with pyproject.toml pyproject.toml is the modern way of listing package metadata. Since this library is not doing anything complex in the build process the setup.py is no longer needed. * Fix find packages
This was referenced Sep 12, 2025
Closed
Contributor
|
Hi @gentlegiantJGC, Thank you for the improvements! Can you please open
as a separate PR and we will merge it? 🙏 -> #281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a number of improvements that I have made in a fork.
You may want to merge each as a new pull request into your repo.
I originally intended to create a pull request for each but some depended on the previous commits and waiting for each to get accepted would have taken a while.
Remove deprecated python versions #284
Add JetBrains .idea folder to .gitignore #282
Simplify test matrix #283
Add 3.9 stubsUpdate black for Python 3.12 stubs #288
Add error logs for each pybind11 version
Add tests for pybind11 v3.0
Replace setup.py with pyproject.toml #281