Updating cluster module and ACOM for cluster based strain mapping #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smribet
reviewed
Sep 29, 2025
py4DSTEM/process/utils/cluster.py
Outdated
| return_similarity : if True, return the similarity array | ||
| """ | ||
| if self.r_space_mask is None: | ||
| self.set_mask(r_space_mask) |
Collaborator
There was a problem hiding this comment.
I don't think this function exists
smribet
reviewed
Sep 29, 2025
py4DSTEM/process/utils/cluster.py
Outdated
| sim_averaged = np.mean(self.similarity, axis=2) | ||
|
|
||
| # Assigning the background as 'counted' | ||
| sim_averaged[~self.r_space_mask] = -1.0 |
Collaborator
There was a problem hiding this comment.
This is causing errors. I would add checking earlier that your r_space_mask is a boolean array. If it is None you'll need to handle this earlier too.
Collaborator
|
Hi @serinlee1065, thanks for submitting this! I adjusted the doc strings and deleted old code that was commented out. I removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating cluster module and ACOM to use cluster dataset for strain mapping