Skip to content

Conversation

@dpostolovski
Copy link
Contributor

@dpostolovski dpostolovski commented Mar 26, 2021

  • Closes GFS Forecasts error #1202

  • I am familiar with the contributing guidelines

  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).

  • Pull request is nearly complete and ready for detailed review.

  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Some products have been renamed in the new version of the GFS model, as can be seen by their changelog

Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dpostolovski

@wholmgren wholmgren merged commit 1ebe7b0 into pvlib:master Mar 29, 2021
@wholmgren wholmgren added this to the 0.9.0 milestone Mar 29, 2021
@wholmgren wholmgren added the bug label Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFS Forecasts error

2 participants