Reindl model bug fix to close #1153 #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
approved these changes
Feb 1, 2021
wholmgren
approved these changes
Feb 1, 2021
| result = irradiance.reindl( | ||
| 40, 180, irrad_data['dhi'], irrad_data['dni'], irrad_data['ghi'], | ||
| dni_et, ephem_data['apparent_zenith'], ephem_data['azimuth']) | ||
| # values from matlab 1.4 code |
Member
There was a problem hiding this comment.
does this comment need to be updated?
Member
There was a problem hiding this comment.
I think it's OK, can't have been meant literally since Matlab doesn't produce np.nan.
wholmgren
reviewed
Feb 1, 2021
| (:issue:`1065`, :pull:`1140`) | ||
|
|
||
| * Reindl model fixed to generate sky_diffuse=0 when GHI=0. | ||
| (:issue:'1153', :pull:'1154', :ghuser:'jsstein') |
Member
There was a problem hiding this comment.
Suggested change
| (:issue:'1153', :pull:'1154', :ghuser:'jsstein') | |
| (:issue:`1153`, :pull:`1154`, :ghuser:`jsstein`) |
Member
There was a problem hiding this comment.
I was about to merge when I noticed these single quotes need to be back ticks.
Traditionally we've not put contributor names next to individual lines in the what's new file, but I have no objection to it. I guess I'd still put the contributor name at the end, too.
Contributor
Author
There was a problem hiding this comment.
I just pushed a formatting correction and removed the contributor info. Thanks for the review!
Member
|
Thanks @jsstein! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] Updates entries todocs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).Added error trapping/exception handling to result in sky diffuse = 0 when GHI=0. Revised the test problem.