Skip to content

⚡ Optimize ShareableMap.clear() with TypedArray.fill() #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

⚡ Optimize ShareableMap.clear() with TypedArray.fill() #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/map/ShareableMap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,7 @@ export class ShareableMap<K, V> extends TransferableDataStructure {
this.acquireWriteLock();
// Reset the index buffer. We do not need to erase the data buffer since it will simply be marked as "free space"
// by the index (and will be overwritten eventually anyways).
for (let i = ShareableMap.INDEX_TABLE_OFFSET; i < this.indexView.byteLength; i += ShareableMap.INT_SIZE) {
this.indexView.setUint32(i, 0);
}
new Uint8Array(this.indexView.buffer, this.indexView.byteOffset, this.indexView.byteLength).fill(0, ShareableMap.INDEX_TABLE_OFFSET);

// Also reset the settings that are stored in the index table
this.indexView.setUint32(ShareableMap.INDEX_USED_BUCKETS_OFFSET, 0);
Expand Down