Skip to content

Conversation

@bastiaanterhorst
Copy link
Contributor

@bastiaanterhorst bastiaanterhorst commented Jun 12, 2025

Description

This adds support for fetching loudness levels. This is used in Plexamp and Dash to show a waveform of the currently playing track. See here for a screenshot of what I mean.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

I have not added tests (yet). Python is not my first language and I'm having a bit of trouble wrapping my head around how the test suite works.

@bastiaanterhorst
Copy link
Contributor Author

bastiaanterhorst commented Jun 12, 2025

Added a basic test that fetches a custom amount of levels and checks the returned list length.

@bastiaanterhorst
Copy link
Contributor Author

@JonnyWong16 no interest in this patch?

Co-authored-by: JonnyWong16 <9099342+JonnyWong16@users.noreply.github.com>
@bastiaanterhorst
Copy link
Contributor Author

Thanks for your review @JonnyWong16. I accepted your changes. Let me know if there is something else you'd like me to take a look at!

@JonnyWong16
Copy link
Collaborator

Please fix flake8 whitespaces.

https://github.com/pushingkarmaorg/python-plexapi/actions/runs/15974729408/job/45090440692?pr=1529

@bastiaanterhorst
Copy link
Contributor Author

I fixed the whitespace issues

@bastiaanterhorst
Copy link
Contributor Author

@JonnyWong16 I think you need to approve the workflows now?

@JonnyWong16 JonnyWong16 merged commit 9d71a81 into pushingkarmaorg:master Jul 7, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants