Skip to content

Simplify reload methods #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JonnyWong16 merged 1 commit into from
Apr 13, 2025
Merged

Simplify reload methods #1515

JonnyWong16 merged 1 commit into from
Apr 13, 2025

Conversation

@JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Apr 9, 2025

Description

Simplify reload methods and makes them all consistent calling _loadData().

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 mentioned this pull request Apr 9, 2025
Merged
9 tasks
@JonnyWong16 JonnyWong16 merged commit 6c6388a into pushingkarmaorg:master Apr 13, 2025
4 of 5 checks passed
@JonnyWong16 JonnyWong16 deleted the feature/refactor_reload branch April 13, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

non-breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JonnyWong16