fix: tx success verification in event confirmer#225
Open
Aman035 wants to merge 2 commits intoaudit-fixesfrom
Open
fix: tx success verification in event confirmer#225Aman035 wants to merge 2 commits intoaudit-fixesfrom
Aman035 wants to merge 2 commits intoaudit-fixesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildOutboundObservation is the success-path constructor - only successful destination txs reach it, which is why
SuccessandErrorMsgare constants.EVM: logs come from eth_getLogs, which by chain protocol only returns logs from txs with receipt status 1.
Solana: meta.logMessages is preserved even when meta.err is set, so in principle a
Program data:line from a failed tx could reach us.I am proposing this as the fix -
Keep the success and errorMsg as it is ( ie hardcoded )
add a tx-status filter in the confirmers - tx.Meta.Err == nill for Solana - svm_event_confirmer
and receipt.Status == 1 for EVM evm_event_confirmer
The EVM one is redundant given
eth_getLogssemantics but keeps the pattern symmetric.Failure handling stays in txresolver (voteOutboundFailureAndMarkReverted), which polls receipts after broadcast and votes
Success: falsefor reverted / not-found txs.