Bump to v2.3.2 and v3.3.2#164
Open
robrobrobrob wants to merge 1 commit intopurpleprotocol:masterfrom
Open
Conversation
Picks up the upstream fix for microsoft/mimalloc#1277, which causes STATUS_ACCESS_VIOLATION (0xC0000005) on aarch64-pc-windows-msvc with mimalloc v3.3.0 / v3.3.1 due to a non-readonly atomic load in the MSVC C atomics wrapper. Fixed upstream in microsoft/mimalloc@60a1f3b, shipped in v3.3.2. Refs purpleprotocol#159.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps both bundled mimalloc submodules to the latest patch releases:
v3submodule:v3.3.1→v3.3.2v2submodule:v2.3.1→v2.3.2Mirrors the pattern of the previous bump (5da8f92 "Bump to v2.3.1 and v3.3.1") — submodule pointer changes only, no build-script or feature-flag changes.
Motivation
mimalloc 3.3.0 and 3.3.1 have a known bug on aarch64-pc-windows-msvc — the MSVC C atomics wrapper emits non-readonly atomic loads that fault when the target page is being unmapped, producing
STATUS_ACCESS_VIOLATION(0xc0000005) at process / thread teardown.Fixed upstream by microsoft/mimalloc@60a1f3b ("update MSVC C atomics wrapper to implement loads as readonly and use more optimal arm instructions (issue #1277)"), shipped in
v3.3.2.This regression is reported here as #159 and is also affecting downstream consumers — e.g. web-infra-dev/rspack#13925, where
@rspack/binding-win32-arm64-msvc@2.0.1segfaults onrequire()and during SWC minify on Windows ARM64 becauselibmimalloc-sys 0.1.47ships the broken mimalloc 3.3.1.Test plan
ubuntu-latest/macos-latest/windows-latest, all 6 feature combos) — will run automatically on this PRwindows-arm64: not performed — this dev box doesn't have MSVC C++ build tools installed. The fix's correctness depends on upstreammicrosoft/mimallocv3.3.2 (validated by their own CI + their #1277 fix verification), and this PR only updates submodule pointers.Refs #159.