Improve graphlib::iterators::Dijkstra API#57
Open
cemeyer wants to merge 2 commits intopurpleprotocol:masterfrom
Open
Improve graphlib::iterators::Dijkstra API#57cemeyer wants to merge 2 commits intopurpleprotocol:masterfrom
cemeyer wants to merge 2 commits intopurpleprotocol:masterfrom
Conversation
We only consume `self` for `iterator: VecDequeue`, which is unused outside of this routine and might as well be a local variable.
While here, drop an unnecessary bare `Option::unwrap()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Dijkstra::new()API computes the single-source shortest path between a given source and every other vertex in the graph. For a consumer that cares about the shortest path between a given source and two or more other graph nodes (e.g.,A→B,A→C, etc), the SSSP computation can be reused. This is more efficient than recomputing it for every destination node (and part of why SSSP is a great algorithm).These changes make reuse more ergonomic by not consuming the value, and referencing the
Dijkstraobject immutably rather than mutably.Previously, one could reuse the results of the SSSP computation only by
clone()ing the entireDijkstraobject, which is inefficient.Tests continue to pass.