Release prep v8.0.0#390
Conversation
|
@bastelfreak @smortex I'm going back and forth on if a major version bump should be done, because of the firewall module bump and platform support drops. |
|
100% this is a major release and should be 8.0.0. And we should include #379 |
| @@ -1,656 +1,580 @@ | |||
| ## puppetlabs-puppetdb changelog | |||
| <!-- markdownlint-disable MD024 --> | |||
There was a problem hiding this comment.
Do we have to rewrite the whole changelog? I think this project uses not the github changelog generator? That allows to put the old changelog in a HISTORY.md and keep it. Makes the diff way more readable.
There was a problem hiding this comment.
Oh crap, the changelog is not generated with the rake changelog task 😒.
I recall triaging all issues in various modules, so I guess we want to do this too for consistency? The current tooling will then generate a full changelog without HISTORY.md on each release, but as the HISTORY.md contain the old changelog, maybe it will not be too bad?
There was a problem hiding this comment.
I labelled issues, and regenerated CHANGELOG.md by hand (because it is not currently in the main branch so the GitHub action does not think it must be updated). This is a PITA only for this release as the next ones will not have this corner case.
68401ce to
c52471f
Compare
c52471f to
9c435ea
Compare
|
Should there be a release after #395 is merged or are there still things that should be waited on? |
|
I wanted to regenerate the CHANGELOG.md, but this fails: https://github.com/puppetlabs/puppetlabs-puppetdb/actions/runs/8642538232/job/23693810562 |
9c435ea to
f5cc979
Compare
Looks like there was some issues in the pdk templates that got fixed. |
|
I guess we want to merge this one: #357 |
Automated release-prep through pdk-templates from commit 5656cdb.
Please verify before merging: