Skip to content

Fix passing deferred password #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deric wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix passing deferred password #1651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/server/db.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# @param instance The name of the Postgresql database instance.
define postgresql::server::db (
String[1] $user,
Optional[Variant[String, Sensitive[String]]] $password = undef,
Optional[Variant[String, Sensitive]] $password = undef,
Optional[String[1]] $comment = undef,
String[1] $dbname = $title,
Optional[String[1]] $encoding = $postgresql::server::encoding,
Expand Down
2 changes: 1 addition & 1 deletion manifests/server/role.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
# @param instance The name of the Postgresql database instance.
define postgresql::server::role (
Boolean $update_password = true,
Variant[Boolean, String, Sensitive[String]] $password_hash = false,
Variant[Boolean, String, Sensitive] $password_hash = false,
Boolean $createdb = false,
Boolean $createrole = false,
String[1] $db = $postgresql::server::default_database,
Expand Down
4 changes: 2 additions & 2 deletions spec/acceptance/db_deferred_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require 'spec_helper_acceptance'

describe 'postgresql::server::db:' do
describe 'postgresql::server::db' do
let(:user) { 'user_test' }
let(:password) { 'deferred_password_test' }
let(:database) { 'test_database' }
Expand All @@ -16,7 +16,7 @@
include postgresql::server
postgresql::server::db { $database:
user => $user,
password => Deferred('unwrap', [$password]),
password => Deferred('unwrap', [Sensitive.new($password)]),
}
MANIFEST
end
Expand Down
Loading