Replace deprecated 'puppet master' terminology with 'Puppet server'#9572
Replace deprecated 'puppet master' terminology with 'Puppet server'#9572stuckvgn wants to merge 1 commit intopuppetlabs:mainfrom
Conversation
Puppet deprecated the 'puppet master' command in favor of 'puppet server' (Puppet Server) several versions ago, but significant documentation, help text, API docs, and code comments throughout the codebase still reference the outdated 'puppet master' terminology. This commit updates user-facing strings, documentation, help text, man pages, API docs, code comments, and localization templates to use 'Puppet server' or 'Puppet Server' as appropriate. Changes span: - CLI help text in application classes (agent, apply, device) - Face descriptions and summaries (catalog, facts, node, plugin, report) - Indirector terminus descriptions - Reference documentation (configuration, function, indirection, report, type) - API endpoint documentation (certificate, report, environments) - Internal documentation (indirector.md, profiling.md) - Man pages (generated troff files) - Localization template (puppet.pot) Note: Acceptance tests and spec files that use 'master' as a Beaker test framework role identifier are intentionally not changed, as 'master' in that context refers to the Beaker DSL, not Puppet terminology. Internal Ruby code that maintains backwards compatibility with the 'master' run mode (e.g., run_mode.rb, settings handling) is also preserved.
|
@stuckvgn it looks like a number of these changes were already made in OpenVoxProject/openvox. I made an attempt to rebase the rest of your changes in OpenVoxProject/openvox#348. We're going to try to have the changes merged for OpenVox 9. Thanks for the contribution. |
|
Thanks @silug for picking this up and doing the rebase work! Great to hear the changes will land in OpenVox 9. Happy to help with OpenVoxProject/openvox#348 if there's anything useful I can contribute — otherwise sounds like you've got it covered. |
|
Closing in favor of the OpenVox fork where @silug has already picked this up in OpenVoxProject/openvox#348. The work is in better hands there — OpenVox is the actively maintained successor for this functionality. Thanks for the context @silug. |
Summary
Puppet deprecated the
puppet mastercommand and replaced it with Puppet Server several major versions ago, but the codebase still contains ~125 references to "puppet master" in user-facing documentation, help text, API docs, and code comments.This PR systematically replaces "puppet master" with "Puppet server" (or "Puppet Server" where referring to the product name) across:
agent,apply,device)catalog,facts,node/clean,plugin,report)configuration,function,indirection,report,type)certificate,certificate_request,certificate_revocation_list,certificate_status,environments,report)indirector.md,profiling.md)puppet.pot)generatefunctionWhat is NOT changed
masteras a Beaker test framework role identifier (this is Beaker DSL, not Puppet terminology)masterrun mode:masterrun mode (run_mode.rb, settings handling, route configuration)puppet master --compilereferences are updated topuppet catalog compile(the modern equivalent)51 files changed, 125 lines replaced (1:1 substitution, no functional changes)
Test plan
puppet agent --help,puppet apply --help,puppet device --helpshow updated textpuppet plugin --help,puppet catalog --help,puppet facts --help,puppet report --help,puppet node --helpshow updated descriptionsman puppet-agent,man puppet-catalog, etc.