docs(artifacts): file REQ-087..090 — export bugs + diagnostic consistency + release bundle#317
Open
avrabe wants to merge 1 commit into
Open
docs(artifacts): file REQ-087..090 — export bugs + diagnostic consistency + release bundle#317avrabe wants to merge 1 commit into
avrabe wants to merge 1 commit into
Conversation
…ency + release bundle Captures four findings from auditing the v0.11.1 / v0.12.0 output against a real 5120-artifact project: - REQ-087: `rivet export --html --single-page` and `--filter` silently emit the full artifact set on large projects (F2-class silent failure — flags claim semantics the implementation does not deliver). - REQ-088: HTML exporter embeds the full CSS/JS framework per page (rivet-cli/src/main.rs:8142-8143; MERMAID_JS = include_str! mermaid.min.js ~3MB). 4000+ pages * 3MB = ~13 GB by construction; user measured exactly that. Fix: extract to shared `_assets/`. - REQ-089: VSIX extension, `rivet serve`, and `rivet validate` surfaced different warning sets for the same project in v0.11.1. No integration test asserts the three rendering paths agree — itself an F2-class silent failure on the QA surface. - REQ-090: GitHub Release should attach a ~51 MB compliance bundle (documents + coverage + matrix + validate + ReqIF) auditors actually need, not the navigation-shell HTML the v0.12.0 release attached. Gated on REQ-088 landing first. All four are v0.13.0-track. No code changes here — these are filings so the path is documented; implementation is its own work. Refs: REQ-005, FEAT-135
📐 Rivet artifact delta
Graphgraph LR
REQ_087["REQ-087"]:::added
REQ_088["REQ-088"]:::added
REQ_089["REQ-089"]:::added
REQ_090["REQ-090"]:::added
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Added
Posted by |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: ca3396b | Previous: 78f001e | Ratio |
|---|---|---|---|
validate/10000 |
15800688 ns/iter (± 1531757) |
12714592 ns/iter (± 1456890) |
1.24 |
traceability_matrix/100 |
5216 ns/iter (± 94) |
4296 ns/iter (± 730) |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four findings from auditing v0.11.1 / v0.12.0 output against a real
5120-artifact project — all filed as v0.13.0-track requirements with
executable Acceptance blocks; no code changes here.
rivet export --html --single-pageand--filtersilently emit the full artifact set on large projects (F2-class
silent failure: flags claim semantics the implementation does not
deliver). Verified plausible: `cmd_export_html` does branch on
`single_page` (`main.rs:8007`) but something in the path still
emits the per-artifact tree at scale.
per page (`main.rs:8142-8143`; `MERMAID_JS = include_str!`
mermaid.min.js ~3MB). 4000+ pages × 3MB = ~13 GB by construction;
user measured exactly that. Fix is well-bounded: extract to shared
`_assets/`; per-page payload drops to ~50KB.
validate` surfaced different warning sets for the same project in
v0.11.1. No integration test asserts the three rendering paths
agree — itself an F2-class silent failure on the QA surface.
bundle (`documents/` + `coverage/` + `matrix/` + `validate/`
actually need — not the navigation-shell HTML the v0.12.0 release
attached. Gated on REQ-088 landing first (until per-page assets
are de-duplicated, the per-artifact pages cannot be cleanly
included).
Test plan
yet satisfied" INFO on each of the four new REQs.
🤖 Generated with Claude Code