build: bump rules_rocq_rust to e4660cc (hermetic rules_rust toolchain)#314
Merged
Conversation
Picks up the rocq-of-rust toolchain migration to hermetic rules_rust (#34 in pulseengine/rules_rocq_rust), now at the tip of that repo's main. The previous pin (6a8da0b) predates that rework; the new commit is the build the upstream is currently shipping. Should reduce the Rocq CI job's coupling to ambient Rust toolchains.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 3364167 | Previous: 0c4d30b | Ratio |
|---|---|---|---|
validate/10000 |
19042835 ns/iter (± 1820411) |
13974853 ns/iter (± 756219) |
1.36 |
diff/10000 |
12634131 ns/iter (± 860358) |
9464945 ns/iter (± 735909) |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the `rules_rocq_rust` git pin in `MODULE.bazel` from
`6a8da0b` to `e4660cc` (current tip of
`pulseengine/rules_rocq_rust` main), picking up
#34 — build: migrate rocq-of-rust to a hermetic rules_rust toolchain.
Reduces the Rocq CI job's coupling to ambient Rust toolchains.
Test plan
migration. (Rocq remains `continue-on-error` until the
Rocq 9.0 port PR; this bump is a build/plumbing improvement,
not a proof-content fix.)
🤖 Generated with Claude Code