chore(deps): bump rules_rocq_rust to e4660cc (rules_rust migration; fixes Rocq Formal Proofs CI)#141
Open
avrabe wants to merge 1 commit into
Open
chore(deps): bump rules_rocq_rust to e4660cc (rules_rust migration; fixes Rocq Formal Proofs CI)#141avrabe wants to merge 1 commit into
avrabe wants to merge 1 commit into
Conversation
Picks up pulseengine/rules_rocq_rust#34 which migrates rocq-of-rust to a hermetic rules_rust toolchain, replacing the ad-hoc cargo build in coq_of_rust/private/repository.bzl. The old build failed on the CI runner with `rust-lld: error: unable to find library -lLLVM-19-rust-1.85.0-nightly`, which has kept the Rocq Formal Proofs CI check red on main since v1.0.5 (admin-merged through it for the v1.1.0 and v1.1.1 releases). Closes the v1.1.1 carry-forward item (task #89). Trace: REQ-12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up pulseengine/rules_rocq_rust#34 which migrates
rocq-of-rustto a hermeticrules_rusttoolchain, replacing the ad-hoccargo buildincoq_of_rust/private/repository.bzl.The old build was failing on the CI runner with
rust-lld: error: unable to find library -lLLVM-19-rust-1.85.0-nightly, keeping theRocq Formal ProofsCI check red on main since v1.0.5 and forcing admin-merge through it for the v1.1.0 and v1.1.1 releases.rules_rocq_rustPR #34's own CI confirms the migrated toolchain builds (Build Example (Linux)and(macOS)both pass).Closes
Test plan
Rocq Formal ProofsCI check on this PR goes green (the whole point)