Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions babel.config.js

This file was deleted.

9 changes: 2 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@
"name": "event-kit",
"version": "2.5.3",
"description": "Simple library for implementing and consuming evented APIs",
"main": "./dist/event-kit",
"main": "./lib/event-kit.js",
"scripts": {
"build": "cross-env BABEL_KEEP_MODULES=false babel lib --out-dir dist --delete-dir-on-start",
"docs": "joanna-tello -o api.json package.json lib",
"prepublish": "npm run build && npm run docs",
"prepublish": "npm run docs",
"test": "jasmine-focused --captureExceptions --forceexit spec"
},
"repository": {
Expand All @@ -18,10 +17,6 @@
},
"license": "MIT",
"devDependencies": {
"@babel/cli": "^7.12.10",
"@babel/core": "^7.12.10",
"babel-preset-atomic": "^3.0.1",
"cross-env": "^7.0.3",
"jasmine-focused": "^1.0.7",
"joanna": "https://github.com/aminya/joanna"
}
Expand Down
3 changes: 1 addition & 2 deletions spec/composite-disposable-spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const CompositeDisposable = require("../dist/composite-disposable")
const Disposable = require("../dist/disposable")
const { CompositeDisposable, Disposable } = require("../lib/event-kit.js");

describe("CompositeDisposable", function() {
let disposable1, disposable2, disposable3
Expand Down
23 changes: 11 additions & 12 deletions spec/disposable-spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const Disposable = require("../dist/disposable")
const { Disposable } = require("../lib/event-kit.js");

describe("Disposable", function() {
it("does not try to execute disposalAction when it is not a function", function() {
Expand All @@ -23,19 +23,18 @@ describe("Disposable", function() {
expect(disposalAction.callCount).toBe(1)
})

it('can be extended by ES5-style classes', () => {
function MyDisposable () {
// super
Disposable.apply(this, arguments)
it("can be extended by ES6-style classes", () => {
class MyDisposable extends Disposable {
constructor(...args) {
super(...args);
}
}

MyDisposable.prototype = new Disposable()

let actionCalled = false
const disposable = new MyDisposable(() => { actionCalled = true })
disposable.dispose()
expect(actionCalled).toBe(true)
})
let actionCalled = false;
const disposable = new MyDisposable(() => { actionCalled = true });
disposable.dispose();
expect(actionCalled).toBe(true);
});

describe(".isDisposable(object)", () => {
it("true if the object implements the ::dispose function", function() {
Expand Down
2 changes: 1 addition & 1 deletion spec/emitter-spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const Emitter = require("../dist/emitter")
const { Emitter } = require("../lib/event-kit.js");

describe("Emitter", function() {
it("invokes the observer when the named event is emitted until disposed", function() {
Expand Down
Loading