Update the “Building Pulsar” docs…

[savetheclocktower]

…to agree with the status quo.

This addresses pulsar#1394 (to some extent) and adds some commented-out paragraphs that we can uncomment if/when pulsar#1397 lands.

This was all verified on both macOS and Linux (Fedora in a VM), but I'm more than happy for someone to double-check my work for Windows.

[ottok]

Looking good! You might also want to mention that running yarn without any arguments will list the available targets with a short documentation.

The dependency list for Debian/Ubuntu in this PR (apt install build-essential libsecret-1-dev libx11-dev libxkbfile-dev libxkbcommon-dev libxkbcommon-x11-dev libxkbcommon0 xkb-data libwayland-dev libwayland-client0) is not aligned with what I tested and documented in https://github.com/pulsar-edit/pulsar/pull/1395/files#diff-75c2b1fceb565d09588af47ddab567f69ba409731750c7fe732a83a17960b94cR12-R36 and pulsar-edit/pulsar#1398 but better than old version for sure.

[savetheclocktower]

The dependency list for Debian/Ubuntu in this PR (apt install build-essential libsecret-1-dev libx11-dev libxkbfile-dev libxkbcommon-dev libxkbcommon-x11-dev libxkbcommon0 xkb-data libwayland-dev libwayland-client0) is not aligned with what I tested and documented in https://github.com/pulsar-edit/pulsar/pull/1395/files#diff-75c2b1fceb565d09588af47ddab567f69ba409731750c7fe732a83a17960b94cR12-R36 and pulsar-edit/pulsar#1398 but better than old version for sure.

yarn and node-gyp should not be necessary given that we recommend people use nvm or a similar tool. But I can update the PR to reflect this list:

python3-setuptools
make
g++
pkg-config
libwayland-dev
libxkbcommon-x11-dev
libxkbfile-dev

But to be clear: are you saying libsecret-1-dev was not necessary for you?

[ottok]

But to be clear: are you saying libsecret-1-dev was not necessary for you?

For building Pulsar or running Electron, no. As you can see from the objdumps, it is not a dependency of Electron for sure. But I don't know if there is some feature somewhere that will require it later at run time. All my testing and my PRs are based on testing in clean containers what are the actual real dependencies currently. I don't know fully why they are depencendies though.

[savetheclocktower]

Fair enough. I might keep libsecret-1-dev in the list just in case until we figure that out.