Skip to content

CI: Add tests workflow, for PRs and default branch pushes#4

Closed
DeeDeeG wants to merge 1 commit into
masterfrom
add-tests-workflow
Closed

CI: Add tests workflow, for PRs and default branch pushes#4
DeeDeeG wants to merge 1 commit into
masterfrom
add-tests-workflow

Conversation

@DeeDeeG
Copy link
Copy Markdown
Member

@DeeDeeG DeeDeeG commented May 31, 2026

Follow-up to #2.

(Marking as draft -- needs package-lock.json, as anticipated to land as part of that PR, #2).

@DeeDeeG DeeDeeG marked this pull request as draft May 31, 2026 04:15
@DeeDeeG DeeDeeG force-pushed the add-tests-workflow branch from 1d7dc72 to ca5a2f6 Compare May 31, 2026 04:21
@savetheclocktower
Copy link
Copy Markdown

This workflow works great, but the tests don't. I explain why in #5, and I brought the workflow file from this PR into #5 as well.

@DeeDeeG
Copy link
Copy Markdown
Member Author

DeeDeeG commented May 31, 2026

Can we land this before #5, then, so I can get authorship credit?

EDIT: See below. (I did spend a lot of time on it, for the record! But it's not really mine to claim.)

@DeeDeeG DeeDeeG marked this pull request as ready for review May 31, 2026 22:36
@DeeDeeG
Copy link
Copy Markdown
Member Author

DeeDeeG commented May 31, 2026

Although, to be fair, this is mostly copy-pasted from stuff I think @confused-Techie wrote in other repos, even if I took care to manually verify the details, and ensure the synthesized final result fit to this repo did actually work here, it's not really original to me, all the same. So, nah. Closing in favor of #5.

@DeeDeeG DeeDeeG closed this May 31, 2026
@DeeDeeG DeeDeeG mentioned this pull request May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants