Add NAME_FILTER_OPTIONS to FileContent relative_path filter#7720
Merged
Conversation
dkliban
force-pushed
the
file-content-filter-options
branch
3 times, most recently
from
29684e5 to
963b4f4
Compare
gerrod3
requested changes
May 15, 2026
| fields = ["relative_path", "sha256"] | ||
| fields = { | ||
| "relative_path": NAME_FILTER_OPTIONS, | ||
| "digest": ["exact"], |
Contributor
There was a problem hiding this comment.
This should still be sha256.
Suggested change
| "digest": ["exact"], | |
| "sha256": ["exact"], |
Member
Author
There was a problem hiding this comment.
Reverted back to "digest". When Meta.fields is a dict, django-filter requires model field names as keys — sha256 is a declared CharFilter alias, not a model field, so it raises TypeError: Meta.fields must not contain non-model field names: sha256. The sha256 = CharFilter(field_name="digest") on the class still provides the ?sha256= query parameter for backwards compatibility.
dkliban
force-pushed
the
file-content-filter-options
branch
from
963b4f4 to
337472e
Compare
FileContentFilter only supported exact matching on relative_path. Use NAME_FILTER_OPTIONS to enable contains, startswith, regex, and other lookup expressions, consistent with other content filters. Fixes pulp#7719 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dkliban
force-pushed
the
file-content-filter-options
branch
from
337472e to
7815029
Compare
gerrod3
approved these changes
May 18, 2026
Member
Author
|
The test failure is unrelated to these changes. It is being addressed in #7730. I am merging this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NAME_FILTER_OPTIONSforrelative_pathinFileContentFilter, enabling contains, startswith, regex, and other lookup expressionsfieldsfrom a list to a dict to specify per-field filter optionssha256query parameter continues to work via the existingCharFilteraliasFixes #7719
Test plan
?relative_path__contains=foo,?relative_path__startswith=packages/,?relative_path__regex=.*\.rpm$