Skip to content

synchronization fix#381

Open
mjuskiewicz66 wants to merge 2 commits intopulp:mainfrom
mjuskiewicz66:main
Open

synchronization fix#381
mjuskiewicz66 wants to merge 2 commits intopulp:mainfrom
mjuskiewicz66:main

Conversation

@mjuskiewicz66
Copy link
Copy Markdown

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

Additional information: This PR attempts to fix #331

@jobselko
Copy link
Copy Markdown

@mjuskiewicz66 Could you please add a changelog entry as described in the checklist in the PR description, and include some tests based on what was mentioned in the issue? Thanks!

@mjuskiewicz66
Copy link
Copy Markdown
Author

Changelog entry added.

@mjuskiewicz66
Copy link
Copy Markdown
Author

Regarding tests, I don’t feel familiar enough with the entire project to write them. Testing this specific function requires extensive setup and mocking, and I’m unsure how to approach that.

@jobselko
Copy link
Copy Markdown

Regarding tests, I don’t feel familiar enough with the entire project to write them. Testing this specific function requires extensive setup and mocking, and I’m unsure how to approach that.

Thanks for the update! Would it be okay if I add tests for this in a separate PR sometime next week? I can include you as a co-author so your work is acknowledged. Let me know if that works for you.

@mjuskiewicz66
Copy link
Copy Markdown
Author

Yeah, that works for me. Thanks!

@jobselko
Copy link
Copy Markdown

jobselko commented Apr 2, 2026

Hi @mjuskiewicz66, I opened #386. Could you please check if my commit where I added you as co-author has the correct name and email? Thanks!

@mjuskiewicz66
Copy link
Copy Markdown
Author

Hey @jobselko, there is a small typo in my username, it's mjuskiewicz66. And the email is michal.juskiewicz@blik.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with synchronizig packages,

2 participants