Support pulpcore 3.107's atomic distribution feature#2301
Conversation
|
I think 2.15 can be dropped from the |
|
Hmm, this one actually does require a pulpcore bump since it defers to pulpcore itself for some of the logic I could either:
or
|
gerrod3
left a comment
There was a problem hiding this comment.
We should backport this.
gerrod3
left a comment
There was a problem hiding this comment.
I had this on the review tab and didn't see the failing tests. Can you try this. I think that will simplify the backports and allow us to not have to bump pulpcore.
| fields = super().distribution_extra_fields(repository, upstream_distribution) | ||
| fields["private"] = upstream_distribution["private"] | ||
| fields["description"] = upstream_distribution["description"] | ||
| return fields |
There was a problem hiding this comment.
Can you try just popping the publication field? I think that would make the tests pass.
|
Let me know which approach you want to take & I'll squash. |
Backport to 2.20: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply de8e655 on top of patchback/backports/2.20/de8e65549b81d79e6884b1b28df11eb70c31467d/pr-2301 Backporting merged PR #2301 into main
🤖 @patchback |
Backport to 2.19: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply de8e655 on top of patchback/backports/2.19/de8e65549b81d79e6884b1b28df11eb70c31467d/pr-2301 Backporting merged PR #2301 into main
🤖 @patchback |
Backport to 2.26: 💚 backport PR created✅ Backport PR branch: Backported as #2302 🤖 @patchback |
Backport to 2.22: 💚 backport PR created✅ Backport PR branch: Backported as #2303 🤖 @patchback |
Backport to 2.24: 💚 backport PR created✅ Backport PR branch: Backported as #2304 🤖 @patchback |
Backport to 2.27: 💚 backport PR created✅ Backport PR branch: Backported as #2305 🤖 @patchback |
📜 Checklist
See: Pull Request Walkthrough