fix(UI): Fix details page Project Link urls#17
Open
CryptoRodeo wants to merge 1 commit intopulp:mainfrom
Open
Conversation
Project links in the details page navigated to localhost (e.g. http://localhost:3000/homepage,%20https://scipy.org/) because Pulp returns `project_urls` as an array of "label, url" strings rather than a Record<string, string> object. Object.entries() on the array produced numeric indices as labels and the full "label, url" string as the href, which the browser treated as a relative path. This Normalizes project_urls at the consumption point in MetadataSidebar to handle both the array format (split on first ", ") and the standard object format. Signed-off-by: Bryan Ramos <bramos@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project links in the details page navigated to localhost (e.g. http://localhost:3000/homepage,%20https://scipy.org/) because Pulp returns
project_urlsas an array of "label, url" strings rather than a Record<string, string> object.Object.entries() on the array produced numeric indices as labels and the full "label, url" string as the href, which the browser treated as a relative path.
This Normalizes project_urls at the consumption point in MetadataSidebar to handle both the array format (split on first ", ") and the standard object format.
Before:
After:
