When creating a pre-populated domain, we are missing a group

[YasenT]

Summary by Sourcery

Ensure domain creation always associates the user with a dedicated auto-created group when no explicit group_name is provided, and update tests accordingly.

Bug Fixes:

• Fix domain creation so that a pre-populated domain does not skip creating a domain-specific group when the user already belongs to other groups.

Tests:

• Extend group-resolution tests to cover the case where an auto group is created even when the user already has groups, and adjust expectations to match the new behavior.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates domain creation group resolution so that a domain-specific group is always created or reused when no group_name is provided, even if the user already has groups, and aligns tests and logging with the new behavior.

Flow diagram for updated domain group resolution in post

flowchart TD
    A[post called with domain_name and optional group_name] --> B{group_name provided}

    B -- Yes --> C[Group.objects.get_or_create name=group_name]
    C --> D[Assign group to user using user.groups.add]

    B -- No --> E[Set group_name to domain-domain_name]
    E --> F[Group.objects.get_or_create name=group_name]
    F --> D

    D --> G[Continue domain creation response]

Loading

File-Level Changes

Change	Details	Files
Change group resolution logic to always use a domain-scoped auto group when no group_name is provided, regardless of existing user groups.	Replace conditional that only created an auto group when the user had no groups with unconditional auto-group creation when group_name is absent. Remove branch that reuses the user’s first existing group instead of a domain-specific group. Ensure the resolved group is created or fetched via Group.objects.get_or_create and then added to the user.	pulp_service/pulp_service/app/viewsets.py
Align tests and test naming with the new group resolution behavior and logging.	Update group-resolution test docstring to no longer advertise exactly three paths. Change the existing-user-group test to expect creation/lookup of the domain auto-group and adding it to the user’s groups, instead of reusing an existing group. Adjust test assertions to verify get_or_create and user.groups.add interactions for the auto-created group.	pulp_service/pulp_service/tests/unit/test_create_domain_view.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}