Intgerate Spatz into Snitch Cluster#319
Draft
DiyouS wants to merge 24 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current known problems:
snitch_pkg.sv: spatz_core needsnitch_pkgfor theamo_edefines, but it locates insnitch_cluster. We can have it in both repos, and it will work well if snitch_cluster is the top-level, however, it will break down when both repos are dependencies (like in Gwaihir), where we cannot ensure the order of overwriting.riscv_opcodes.sv. Spatz needs one, and snitch_cluster also needs it. Currently, I manually copy the one generated in snitch_cluster to spatz_core and remove it from theBender.ymlin snitch_cluster.snitch.sv(can be reproduced when settingsnitch_cluster_wrapperas module name in spyglass check), not related to Spatz integrationThe most appropriate approach is to use snitch_core as a separate dependency/repo, which both spatz_core and snitch_cluster depend on. This could solve all problems of circular dependency. A temporary walkaround only adds one in spatz_core, and uses spatz_core as the dependency of snitch_cluster (like what I did to
riscv_opcodes). We may also need to force the update of the generated file from Makefile to ensure it is updated to the version we need.