Align performance counters for CV32E40P #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NBruschi
reviewed
Aug 11, 2021
| PULP_LDFLAGS += | ||
| PULP_CFLAGS += -D__riscv__ -DARCHI_HAS_COREV -DPLP_NO_BUILTIN | ||
| # Define the toolchain under use with CV32E40P. Options are `PULP_TOOLCHAIN` or `COREV_TOOLCHAIN` | ||
| TOOLCHAIN = PULP_TOOLCHAIN |
Contributor
There was a problem hiding this comment.
The users should not modify the architecture specific makefile to avoid confusion. I propose something like the following:
PULP_CC ?= $(shell (basename $(PULP_RISCV_GCC_TOOLCHAIN)/bin/*-gcc))
PULP_LD ?= $(shell (basename $(PULP_RISCV_GCC_TOOLCHAIN)/bin/*-gcc))
PULP_OBJDUMP ?= $(shell (basename $(PULP_RISCV_GCC_TOOLCHAIN)/bin/*-objdump))
PULP_AR ?= $(shell (basename $(PULP_RISCV_GCC_TOOLCHAIN)/bin/*-ar))
ifeq ($(PULP_CC), riscv32-corev-elf-gcc)
__COREV_TOOLCHAIN_FLAGS__
else
__PULP_TOOLCHAIN_FLAGS__
endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR alignes performance counters in CV32E40P for RTL verification.
Checklist
Note
At the moment, each counter has been associated to one event arbitrarily, following the same approach employed in pulp-runtime. This has almost zero-impact from a user-level viewpoint for what concerns APIs.
Further solutions to make performance counters and events more dynamic can be addressed in future PRs