-
Notifications
You must be signed in to change notification settings - Fork 57
Migrate hardware dependencies from Git submodules to Bender #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for this work. Please address the comments, rebase and change the |
…arget is called. Also add clean-deps target to clean all the deps.
87eb9e4 to
9f7fa9d
Compare
34338f8 to
8cb5805
Compare
mbertuletti
approved these changes
Dec 10, 2025
Collaborator
mbertuletti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the hardware patches in the repo to avoid to check out bender dependencies in the hardware deps workspace.
- For
register_interfaceI waived linter errors and verilator warnings on the generated files. - For
tech_cells_genericI removed the patch for hardware DPIs on thetc_srammacro and created a wrapper in themempool_system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize the changes concisely
Changelog
Added
Changed
bender: Remove all hardware git submodules, switch to bender.
Remove hardware git submodule init in ci scripts.
Checklist