Draft
Conversation
fischeti
force-pushed
the
fischeti/slang-pickler
branch
2 times, most recently
from
faf42ab to
a8e840c
Compare
micprog
force-pushed
the
fischeti/slang-pickler
branch
from
448dbbf to
d92fb2f
Compare
fischeti
force-pushed
the
fischeti/slang-pickler
branch
2 times, most recently
from
7dd5086 to
ac6988a
Compare
fischeti
force-pushed
the
fischeti/slang-pickler
branch
3 times, most recently
from
95757fe to
79a2d1d
Compare
fischeti
force-pushed
the
fischeti/slang-pickler
branch
2 times, most recently
from
6992fdb to
9526ab2
Compare
Will result in ABI mismatches i.e. segfaults otherwise
Prevent multiple inclusion of the header by adding a traditional #ifndef/define/endif include guard (BENDER_SLANG_BRIDGE_H). This replaces the lone #pragma once for better portability and ensures the header can be safely included multiple times across translation units.
fischeti
force-pushed
the
fischeti/slang-pickler
branch
from
9526ab2 to
e94b860
Compare
fischeti
force-pushed
the
fischeti/slang-pickler
branch
from
36d26ce to
461ef7a
Compare
Introduce safe wrapper types for the opaque FFI objects and move the
extension methods into proper Rust structs to provide a clearer,
idiomatic API and safer ownership semantics.
- Add SyntaxTree wrapper around SharedPtr<ffi::SyntaxTree> with Clone,
display, as_debug, rename, and fmt impls (Display/Debug).
- Add SlangContext wrapper around UniquePtr<ffi::SlangContext> with new,
set_includes, set_defines, and parse returning a SyntaxTree.
- Replace new_session() to return SlangContext instead of raw pointer.
- Update callers: remove use of extension traits and change formatting
at pickling to use Debug/Display impls (write!("{:?}", renamed_tree)).
fischeti
force-pushed
the
fischeti/slang-pickler
branch
3 times, most recently
from
6dfa15f to
2447060
Compare
fischeti
force-pushed
the
fischeti/slang-pickler
branch
from
2447060 to
861b6ab
Compare
fischeti
force-pushed
the
fischeti/slang-pickler
branch
from
e17eb1e to
1dbe291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 1 of 2 in a stack made with GitButler:
slangbindings and pickler #264 👈