Skip to content

Conversation

@micprog
Copy link
Member

@micprog micprog commented Oct 6, 2025

Fixes #208

Copy link
Contributor

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out on an example that is similar to what is described in #208. However, I get the following behaviour:

  1. bender clone A still works, and it does not update the path of B in Bender.lock i.e. it still points to the one in .bender. Which I think is fine.
  2. bender clone B throws an error, but not the new one I would expect i.e. I get a fatal: '".bender/path/to/path_dep"' does not appear to be a git repository

Shouldn't the second case throw the new errorDependency is not a git dependency, cannot clone.?

@micprog
Copy link
Member Author

micprog commented Dec 10, 2025

I tried it out on an example that is similar to what is described in #208. However, I get the following behaviour:

1. `bender clone A` still works, and it does not update the path of `B` in Bender.lock i.e. it still points to the one in `.bender`. Which I think is fine.

2. `bender clone B` throws an error, but not the new one I would expect i.e. I get a `fatal: '".bender/path/to/path_dep"' does not appear to be a git repository`

Shouldn't the second case throw the new errorDependency is not a git dependency, cannot clone.?

I updated the implementation to properly handle 1., i.e., also redirecting the dependency path for path dependencies in git dependencies.

I was not able to reproduce 2.

Copy link
Contributor

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retried and both scenarios now do what they are meant to do👍

@micprog micprog merged commit c5b482e into master Dec 11, 2025
6 checks passed
@micprog micprog deleted the clone_cleanup branch December 11, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bender clone on Path Subdependencies Fails

4 participants