-
Notifications
You must be signed in to change notification settings - Fork 54
Update clone command, fail cloning of path deps #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0e27e28 to
b4d7a92
Compare
b4d7a92 to
20c5278
Compare
fischeti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out on an example that is similar to what is described in #208. However, I get the following behaviour:
bender clone Astill works, and it does not update the path ofBin Bender.lock i.e. it still points to the one in.bender. Which I think is fine.bender clone Bthrows an error, but not the new one I would expect i.e. I get afatal: '".bender/path/to/path_dep"' does not appear to be a git repository
Shouldn't the second case throw the new errorDependency is not a git dependency, cannot clone.?
8880af2 to
9386e3e
Compare
I updated the implementation to properly handle 1., i.e., also redirecting the dependency path for path dependencies in git dependencies. I was not able to reproduce 2. |
fischeti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I retried and both scenarios now do what they are meant to do👍
89c8b92 to
cc12d6a
Compare
Fixes #208