[HW] Fix VSTU queue overrun (Issue #369)#449
Open
sameh-tensorica wants to merge 4 commits intopulp-platform:mainfrom
Open
[HW] Fix VSTU queue overrun (Issue #369)#449sameh-tensorica wants to merge 4 commits intopulp-platform:mainfrom
sameh-tensorica wants to merge 4 commits intopulp-platform:mainfrom
Conversation
40f3c96 to
dc3230d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vstu (Vector Store Unit) module had a bug reported in issue #369 where it would hang if its instruction queue became full of in-flight issued instructions. This occurred because the pointer-based retirement logic (
issue_pnt != commit_pnt) erroneously returned false when the circular buffer pointers overlapped.Changelog
Fixed
Added
Checklist
Please check our contributing guidelines before opening a Pull Request.