Add mouse HID actions and make NanoKVMClient a context manager

[mangelajo]

This commit adds mouse HID functionality, and provides a
context-manager for the whole NanoKVMClient, in a way that
a separate context manager is not necessary anymore.

This is backwards imcompatible, but it should be easy to switch

from:

    async with ClientSession() as session:
        client = NanoKVMClient("http://kvm-8b76.local/api/", session)
        await client.authenticate("username", "password")

to:

    async with NanoKVMClient("http://kvm-8b76.local/api/", session) as client:
        await client.authenticate("username", "password")

This change provides the new following methods:

• mouse_move_rel
• mouse_move_abs
• mouse_down
• mouse_up
• mouse_click
• mouse_scroll

[puddly]

What about a context manager API? It can be a breaking change. Any async cleanup in __del__ is basically a race condition. Something like this maybe?

async with ClientSession() as session:
    async with NanoKVMClient(...) as client:
        ...

Then, NanoKVMClient.__aenter__ can be a no-op that returns the current object (since the WS connection is opened lazily) and __aexit__ runs the cleanup code in close_ws (which I guess can be made private).

[mangelajo]

I suspect we probably should have constants for the buttons "left" "right" "middle", etc ..

[mangelajo]

What about a context manager API? It can be a breaking change. Any async cleanup in __del__ is basically a race condition. Something like this maybe?

async with ClientSession() as session:
    async with NanoKVMClient(...) as client:
        ...

Then, NanoKVMClient.__aenter__ can be a no-op that returns the current object (since the WS connection is opened lazily) and __aexit__ runs the cleanup code in close_ws (which I guess can be made private).

Yes, you are right.

Look at my last patch, I think it would be clean, and using a context manager, we can even create the ClientSession automatically.

It's made to be backwards compatible. I am testing it out right now. will report back and clear the draft.

[mangelajo]

I can probably pull this all under aexit

[puddly]

If we only support a context manager, yeah, that would be best. I don't think anything will break with a double close but there's no need for public API to close the client explicitly

[mangelajo]

👋 :D

[puddly]

Ah, sorry! I forgot to actually merge and release this 😅